-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question about camera_config.cfg
#8
Comments
The one used in
None is correct since it all depends on how you define xy coordinate in the cameraframe. I think there was some discussion about frames in ctapipe and that they should be changed. But in the end it all depends on how we/they define it. Concerning both mappings:
|
Noooo! This is exactly how I found it Please have a look at the pdf I attached above. On page 1 I show the coordiates of the first 3 pixels. |
I found a discrepancy between
camera_config.cfg
here (and its copy in digigcampipe) and the file namedDigicam.geomcam.fits.gz
in ctapipe, here:https://github.com/cta-observatory/ctapipe-extra/blob/master/ctapipe_resources/DigiCam.camgeom.fits.gz
positions
Here you see a plot of the positions. I used
plt.plot(pix_x, pix_y)
for our own config file andplot(-pix_y, -pix_x)
for the pixel I found in ctapipe in order to make the images look most similar.ids
Okay this plot is a bit busy ...
plotted with
I plotted the pixel positions I found in digicampipe and the pixel positions I found in ctapipe both in one figure (similar to the picture above) .. The facecolor of the circles colorcodes the
pix_id
. The colormap is viridis. So dark-purple is close to zero .. bright-yellow is close to 1296.We see both the coordinates from ctapipe and from digicampipe seem to agree quite well with their
pix_id
s, yellow is up and dark is down .. for both of them .. very nice.The black lines connect pixels having the same
pix_ids
Question:
Can anyone enlighten a bit this situation? Do we know where the ctapipe geometry definition comes from or where it is used? Since I am pretty much an outsider, I even have the question: Which one is correct? I of course trust more our own config file .. but still ctapipe did not just invent these numbers ...
My assumption would be, that at some point in the history, somebody gave some information about the camera layout to ctapipe ... since then the layout changed a bit ... and we updated our config files accordingly, but ctapipe did not .. so their configuration is outdated and ours is correct.
Is my assumption correct?
The text was updated successfully, but these errors were encountered: