-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed mirror types overly restrictive #983
Comments
Hi, yeah to be honest this information is not super useful, the optical configuration should not make any difference to our analysis. What would be useful though is just to store whether the telescope is single mirror or dual mirror. As if we introduce an "engineering camera frame" or something like that we will need to perform a flip of the camera for dual mirror optics at some point. |
To be really useful (I think the muon analysis needs it @AMWMitchell, @rlopezcoto), |
I started refactoring this in #982 |
Completely irrelevant side note: the MST is also not a DC, but of 'intermediate' design with the intention to improve the timing compared to a pure DC design... |
Fixed in #982 |
OpticsDescription
raises errors, if mirror type is not one ofDC
orSC
.This is overly restrictive, as there are many more mirror types, even within CTA, I think the LST for example is a segmented parabolic mirror, not a Davies Cotton.
FACT for example is a hybrid, in between Davies--Cotton and parabolic.
For what is is type actually used? I did not find anything.
The text was updated successfully, but these errors were encountered: