Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed mirror types overly restrictive #983

Closed
maxnoe opened this issue Feb 22, 2019 · 5 comments
Closed

Allowed mirror types overly restrictive #983

maxnoe opened this issue Feb 22, 2019 · 5 comments
Assignees

Comments

@maxnoe
Copy link
Member

maxnoe commented Feb 22, 2019

OpticsDescription raises errors, if mirror type is not one of DC or SC.

This is overly restrictive, as there are many more mirror types, even within CTA, I think the LST for example is a segmented parabolic mirror, not a Davies Cotton.

FACT for example is a hybrid, in between Davies--Cotton and parabolic.

For what is is type actually used? I did not find anything.

@ParsonsRD
Copy link
Member

Hi, yeah to be honest this information is not super useful, the optical configuration should not make any difference to our analysis. What would be useful though is just to store whether the telescope is single mirror or dual mirror. As if we introduce an "engineering camera frame" or something like that we will need to perform a flip of the camera for dual mirror optics at some point.

@maxnoe
Copy link
Member Author

maxnoe commented Feb 22, 2019

To be really useful (I think the muon analysis needs it @AMWMitchell, @rlopezcoto),
one would also need information about the single tiles positions and shadowing, right?

@maxnoe
Copy link
Member Author

maxnoe commented Feb 22, 2019

I started refactoring this in #982

@GernotMaier
Copy link
Contributor

Completely irrelevant side note: the MST is also not a DC, but of 'intermediate' design with the intention to improve the timing compared to a pure DC design...

@maxnoe
Copy link
Member Author

maxnoe commented Mar 5, 2019

Fixed in #982

@maxnoe maxnoe closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants