Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for reading older file versions #1983

Closed
maxnoe opened this issue Jul 1, 2022 · 2 comments
Closed

Remove support for reading older file versions #1983

maxnoe opened this issue Jul 1, 2022 · 2 comments
Milestone

Comments

@maxnoe
Copy link
Member

maxnoe commented Jul 1, 2022

Please describe the use case that requires this feature.
With the planned and already merged changes to the data model (#1923, #1949, #1899, #1426, #1591 and some others) I think we are at the point where we should remove a number of workarounds and compatibility layers to simplify the code.

Describe the solution you'd like

Drop support for all but the current version of the data model to simplify the code.

Describe alternatives you've considered

Keep maintaining these workarounds and compatibility layers. I don't think we should do this, especially not for 1.0.

@maxnoe maxnoe added this to the v0.16.0 milestone Jul 1, 2022
@kosack
Copy link
Contributor

kosack commented Jul 1, 2022

Yes, I think this is ok . we are still in a pre 1.0 release, so shouldn't worry too much about backward compatibility

@maxnoe
Copy link
Member Author

maxnoe commented Jul 4, 2022

This for me would also include removing the support for calculating hillas parameters in CameraFrame. It will improve performance (because the unit checks will not be necessary) and also pave the way for applying pointing corrections in the transform from CameraFrame to TelescopeFrame before calculating hillas parameters.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants