Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce possibility of running ImageExtractor on waveforms with multiple gains #1836

Closed
maxnoe opened this issue Feb 1, 2022 · 1 comment · Fixed by #2529
Closed

Comments

@maxnoe
Copy link
Member

maxnoe commented Feb 1, 2022

Please describe the use case that requires this feature.

Calibration events won't be gain selected, as we need to have calibration coefficients for all pixels for all gains.

Describe the solution you'd like

Make ImageExtractors work with non-gain-selected input again

Describe alternatives you've considered

Using a python loop over the gain channels with ManualGainSelector, but that could be much less efficient for ImageExtractors that could easily be vectorized over multiple gain channels.

@maxnoe
Copy link
Member Author

maxnoe commented Sep 29, 2023

We discussed this during today's developer call.

The conclusion was that we:

a) Want to reintroduce the feature that extractors can work on two gain channels and that should result in two images, one per gain channel

b) R1 and DL0 waveforms should always have the shape (n_channels, n_pixels, n_samples), even if n_channels is 1.

Together with the event type, pixel status and the camera readout, it is then clear whether gain selection has happened or the camera has just one gain.

Hckjs referenced this issue in TjarkMiener/ctapipe Feb 27, 2024
This commit adds a migration proposal for the flatfield and pedestal components from lstchain into ctapipe.

Shared functionality is moved into a parent component, while the different subcomponents hold the _process() function for the conventional processing of flatfield and pedestal events.

Additional subcomponents with complex proccesing routines of flatfield and pedestal events can be added in the future.
@Hckjs Hckjs self-assigned this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants