Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __call__ where apropriate #1024

Closed
dneise opened this issue Mar 22, 2019 · 0 comments
Closed

Use __call__ where apropriate #1024

dneise opened this issue Mar 22, 2019 · 0 comments
Assignees

Comments

@dneise
Copy link
Member

dneise commented Mar 22, 2019

We have some components in ctapipe, which are in principle callables and offer only one real interface, which is to call them:

Possible examples are:

  • CameraCalibrator.calibrate()
  • CameraDL1Calibrator.calibrate()
  • CameraDL0Reducer.reduce()
  • ChargeExtractor.extract_charge()
  • DataVolumeReducer.reduce_waveforms()
  • WaveformCleaner.apply()
  • IntensityFitter.fit()
  • Reconstructor.predict()

In #1022 Max thankfully starting tidying this up. This issue is just a reminder for us to tidy the rest up as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants