Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coordinate transformation deprecated on ctapipe #5

Closed
rlopezcoto opened this issue Jun 20, 2018 · 1 comment
Closed

Coordinate transformation deprecated on ctapipe #5

rlopezcoto opened this issue Jun 20, 2018 · 1 comment

Comments

@rlopezcoto
Copy link
Contributor

After cta-observatory/ctapipe#758,
the coordinate transformation defined in reco/Disp.py is deprecated:
therefore functions as c.alt_to_theta will not work.

Not sure if this was the problem of the disp estimation we discussed offline, but now the disp looks healthier although g/h is still not good.

To keep track, I copy here what I was obtaining before I updated my ctapipe repo with the previous coordinate transformations:
screen shot 2018-06-20 at 11 11 20.
@rlopezcoto
Copy link
Contributor Author

Is this one fully solved with the modifications on the scripts by @misabelber and @vuillaut?

@rlopezcoto rlopezcoto assigned vuillaut and unassigned vuillaut Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vuillaut @rlopezcoto