Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

update to postCSS v8 #142

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update to postCSS v8 #142

wants to merge 3 commits into from

Conversation

the-stas
Copy link

No description provided.

@the-stas
Copy link
Author

@jonathantneal please take a look

.gitignore Show resolved Hide resolved
.tape.js Show resolved Hide resolved
@@ -14,6 +14,7 @@
"index.mjs"
],
"scripts": {
"publish": "npx clean-publish",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonioRedondo
Copy link

It would be nice to have this pull request approved and merged. 🙂

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-stas thanks for initiating the effort to port this to PostCSS 8. Apologies for not getting to this earlier.

We've been working hard on csstools/postcss-plugins and neglected the rest for a bit.

That said, I've left a few comments which I'm open to discussing. Most of the things is to try and keep the same coding style we've been enforcing on all of our recent efforts. The most pressing thing to me is that this is leveraging plugins that are outdated. We've been improving postcss-preset-env a lot and also it wouldn't be fully compatible with V8.

Thanks again!

.gitignore Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Antonio-Laguna
Copy link
Member

It would be nice to have this pull request approved and merged. 🙂

Thanks for pinging on this :)

@AntonioRedondo AntonioRedondo mentioned this pull request Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants