-
Notifications
You must be signed in to change notification settings - Fork 77
update to postCSS v8 #142
base: master
Are you sure you want to change the base?
update to postCSS v8 #142
Conversation
@jonathantneal please take a look |
@@ -14,6 +14,7 @@ | |||
"index.mjs" | |||
], | |||
"scripts": { | |||
"publish": "npx clean-publish", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommended way of publishing per postCSS
https://evilmartians.com/chronicles/postcss-8-plugin-migration#:~:text=Now%20use%20npx%20clean-publish%20instead%20of%C2%A0npm%20publish.
It would be nice to have this pull request approved and merged. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@the-stas thanks for initiating the effort to port this to PostCSS 8. Apologies for not getting to this earlier.
We've been working hard on csstools/postcss-plugins and neglected the rest for a bit.
That said, I've left a few comments which I'm open to discussing. Most of the things is to try and keep the same coding style we've been enforcing on all of our recent efforts. The most pressing thing to me is that this is leveraging plugins that are outdated. We've been improving postcss-preset-env a lot and also it wouldn't be fully compatible with V8.
Thanks again!
Thanks for pinging on this :) |
/index.mjs back
No description provided.