Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow function values to utilize the 'priority' parameter of the style.setProperty method and be able to set it to 'important'. #629

Closed
StevenRasmussen opened this issue Nov 14, 2017 · 2 comments
Closed

Allow function values to utilize the 'priority' parameter of the style.setProperty method and be able to set it to 'important'. #629

StevenRasmussen opened this issue Nov 14, 2017 · 2 comments
Labels
complexity:moderate We talked about it, you can do it! enhancement No kittens die if we don't do that.

Comments

@StevenRasmussen
Copy link

StevenRasmussen commented Nov 14, 2017 •
edited
Loading

When using function values, I need to be able to use '!important'. However, since function values are using the CSSOM 'setProperty' method, the value being set cannot have '!important', see here. In order to be able to use '!important', the setProperty method must utilize the 3rd optional parameter and set it to 'important'.

FYI - This is currently being called in the DomRenderer.js file, line 42.

Thanks!
@kof
Copy link
Member

kof commented Nov 14, 2017

good catch!

@kof kof added complexity:moderate We talked about it, you can do it! enhancement No kittens die if we don't do that. labels Nov 14, 2017
@StevenRasmussen StevenRasmussen mentioned this issue Nov 14, 2017
Closed
@kof
Copy link
Member

kof commented Dec 16, 2017

released in v9.4.0

@kof kof closed this as completed Dec 16, 2017
@kof kof mentioned this issue Dec 16, 2017
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:moderate We talked about it, you can do it! enhancement No kittens die if we don't do that.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kof @StevenRasmussen