Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-jss function values do not work as expected in React 18 #1614

Closed
bsShoham opened this issue May 1, 2022 · 1 comment
Closed

react-jss function values do not work as expected in React 18 #1614

bsShoham opened this issue May 1, 2022 · 1 comment

Comments

@bsShoham
Copy link

bsShoham commented May 1, 2022

Expected behavior:
function values should be rendered into the stylesheet

Describe the bug:
function values in react 18 do not get into the stylesheet.

Reproduction:

the following are two examples of the same code, on with react 17.0.2 and one with react 18.1.0, in the react 17 example the button renders into the html the class (class name) and the function value (color of text), in the 18 example it will not render the value only the class name.

React 17.0.2:
https://codesandbox.io/s/react-jss-react-17-ftlcel?file=/src/App.js

React 18.1.0
https://codesandbox.io/s/react-jss-react-18-sp533b?file=/src/App.js

Versions (please complete the following information):

  • jss: react-jss 10.9.0
  • Browser [e.g. chrome, safari]: Edge (Chromium)
  • OS [e.g. Windows, macOS]: Windows

Managing expectations:

I think that this is due to some breaking changes in React 18, but tbh I have no idea, I just assume further support for react 18 is needed

@bsShoham
Copy link
Author

bsShoham commented May 1, 2022

didn't notice it's a duplicate of #1597
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant