Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student drop modal text overflow in small windows #451

Open
joshualiao opened this issue Oct 24, 2023 · 3 comments
Open

Student drop modal text overflow in small windows #451

joshualiao opened this issue Oct 24, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code sev4 Normal severity - System impaired

Comments

@joshualiao
Copy link

Can't check "blacklist" when you try to ban a student, specifically in a restricted course. Should probably be removing them off the whitelist?

Reproduce: Add a student to a restricted course. Try to remove them by pressing red x. Blacklist window shows up; can't select checkbox to ban.

@ericyche ericyche added good first issue Good for newcomers bug Something isn't working javascript Pull requests that update Javascript code labels Oct 24, 2023
@edwardneo edwardneo added the sev4 Normal severity - System impaired label Oct 24, 2023
@aaudreywu
Copy link

Have you tried clicking these buttons first before checking "blacklist"?
screen_shot_2023-10-30_at_7 51 08_pm_720

@joshualiao
Copy link
Author

Maybe I have something imported wrong locally, if anyone else can reproduce? Specifically, I do this:

in admin/scheduler/course, turn CSM16A into a restricted course and save.
Add a student to CSM16A as a coordinator.
Press the red "x" to remove them.

For me, I get the following:
https://github.com/csmberkeley/csm_web/assets/90676487/11b01fbb-2385-407e-95bc-49cfbe0c25a8
And the blacklist checkbox is not selectable. Curiously, in a non-restricted course, the same thing occurs, but with the ban option that is not selectable instead.

@smartspot2 smartspot2 changed the title Coordinator Blacklist Bug Student drop modal text overflow in small windows Feb 16, 2024
@smartspot2
Copy link
Member

I can't reproduce exactly what you're talking about, but for a small window, the modal does have vertical text overflow, which prevents the user from seeing anything that flows past the bottom of the window (see below). Adding a scrollbar upon overflow would remedy this issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code sev4 Normal severity - System impaired
Projects
None yet
Development

No branches or pull requests

5 participants