Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deselecting item when disabled #168

Closed
1 of 6 tasks
krystxf opened this issue Aug 30, 2022 · 2 comments · Fixed by #169
Closed
1 of 6 tasks

Deselecting item when disabled #168

krystxf opened this issue Aug 30, 2022 · 2 comments · Fixed by #169
Assignees
@csandman
Labels
Bug Something isn't working

Comments

@krystxf
Copy link

krystxf commented Aug 30, 2022

Description

If the selection is disabled (isDisabled={true}), the selected option can still be deselected by clicking on the cross.

image

chakra-react-select Version

2.0.0

Link to Reproduction

No response

TypeScript?

  • Yes I use TypeScript

Steps to reproduce

  1. Select some items
  2. Disable select
  3. Deselect them by clicking on the cross

Operating System

  • macOS
  • Windows
  • Linux
  • iOS/iPadOS
  • Android

Additional Information

No response
@krystxf krystxf added the Bug Something isn't working label Aug 30, 2022
@csandman
Copy link
Owner

Thanks for the bug report! I have figured out what is wrong and will push a new version with a fix shortly.

@csandman csandman mentioned this issue Aug 31, 2022
Merged
@csandman
Copy link
Owner

This is now fixed in v4.1.5! Check out this demo to see it in action:

https://codesandbox.io/s/chakra-react-select-isdisabled-fix-vn24dg?file=/example.js

@lschlesinger lschlesinger mentioned this issue Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csandman csandman

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@csandman @krystxf