Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Latest build doesn't include types #123

Closed
2 of 6 tasks
nvsd opened this issue May 13, 2022 · 2 comments · Fixed by #124
Closed
2 of 6 tasks

[BUG] Latest build doesn't include types #123

nvsd opened this issue May 13, 2022 · 2 comments · Fixed by #124
Assignees
@csandman
Labels
Bug Something isn't working

Comments

@nvsd
Copy link

nvsd commented May 13, 2022

Description

It looks like types weren't included beyond 3.3.3.

chakra-react-select Version

3.3.3

Link to Reproduction

No response

TypeScript?

  • Yes I use TypeScript

Steps to reproduce

  1. Install chakra-react-select
  2. View node-modules/chakra-react-select/dist
  3. Observe types directory missing

Operating System

  • macOS
  • Windows
  • Linux
  • iOS/iPadOS
  • Android

Additional Information

No response
@nvsd nvsd added the Bug Something isn't working label May 13, 2022
@csandman csandman mentioned this issue May 13, 2022
Merged
@csandman csandman mentioned this issue May 13, 2022
Merged
@csandman
Copy link
Owner

csandman commented May 13, 2022 •
edited
Loading

Thanks for the heads up! This has been fixed in v3.3.6 (or v4.0.0-rc.2 for Chakra V2)

@nvsd
Copy link
Author

nvsd commented May 13, 2022

Thanks for the quick turnaround and the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csandman csandman

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the types being built by removing "increcemental" from tsconfig csandman/chakra-react-select
2 participants
@nvsd @csandman