d.SharedSecret undefined

[michielbdejong]

This line throws a nil pointer exception when Marie tries to accept a transfer-create from Einstein: https://github.com/cs3org/reva/blame/94ced01208864b66b21d2c54977c6df548d37974/internal/grpc/services/gateway/ocmshareprovider.go#L429

[michielbdejong]

CC @gmgigi96 @redblom

[redblom]

See pondersource/sciencemesh-php#159 (comment)

The transfers fail because the protocol is not send with the request (pondersource/sciencemesh-php#159 (comment)).
Let's fix both in one go?

[redblom]

Results of the local regular share tests so far:

1. In gateway.ocmshareprovider.createOCMReference the secret is extracted in getTransferProtocol through TransferOptions, this should be WebdavOptions. Consider creating a getWebdavProtocol method.
   2. The targetURL created in gateway.ocmshareprovider.createOCMReference has an incorrect format. The host part also contains the idp schema. Subsequently in gateway.webdavstorageprovider.ExtractEndpointInfo the endpoint extraction fails. The host part in the target url should lack the schema.
   Ok, so this is what the ocmshareprovider provider_domain config setting is for. That needs to be set.

Result of local transfer share tests so far:

1. The transfer protocol is not send with the request, and thus the share will not be recognized as a transfer (see Document rclone setup pondersource/sciencemesh-php#159 (comment)).

[redblom]

Can be closed. Dealt with in PR #3847.