Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run changelog check when there are no changes #1367

Closed
labkode opened this issue Dec 10, 2020 · 0 comments · Fixed by #1385
Closed

Do not run changelog check when there are no changes #1367

labkode opened this issue Dec 10, 2020 · 0 comments · Fixed by #1385
Assignees
@ishank011
Labels
junior-job Easy issues

Comments

@labkode
Copy link
Member

labkode commented Dec 10, 2020 

git clone https://github.com/cs3org/reva
cd reva
make deps && make

will fail with:

go run tools/check-changelog/main.go
2020/12/10 08:52:13 No changelog added. Please create a changelog item based on your changes
exit status 1
make: *** [check-changelog] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishank011 ishank011

Labels
junior-job Easy issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run changelog check only if there are changes in the code ishank011/reva
2 participants
@labkode @ishank011