From 94323341dd6a9f7119784e5d8554fec26091e424 Mon Sep 17 00:00:00 2001 From: Jesse Geens Date: Tue, 8 Oct 2024 09:21:17 +0200 Subject: [PATCH] Replaced oldfind with newfind command --- changelog/unreleased/eos-newfind.md | 5 +++++ pkg/eosclient/eosbinary/eosbinary.go | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelog/unreleased/eos-newfind.md diff --git a/changelog/unreleased/eos-newfind.md b/changelog/unreleased/eos-newfind.md new file mode 100644 index 0000000000..46d22b64d1 --- /dev/null +++ b/changelog/unreleased/eos-newfind.md @@ -0,0 +1,5 @@ +Enhancement: use newfind command in EOS + +The EOS binary storage driver was still using EOS's oldfind command, which is deprecated. We now moved to the new find command, for which an extra flag (--skip-version-dirs) is needed. + +https://github.com/cs3org/reva/pull/4883 \ No newline at end of file diff --git a/pkg/eosclient/eosbinary/eosbinary.go b/pkg/eosclient/eosbinary/eosbinary.go index 10189b7daf..d6addc941c 100644 --- a/pkg/eosclient/eosbinary/eosbinary.go +++ b/pkg/eosclient/eosbinary/eosbinary.go @@ -692,7 +692,7 @@ func (c *Client) Rename(ctx context.Context, auth eosclient.Authorization, oldPa // List the contents of the directory given by path. func (c *Client) List(ctx context.Context, auth eosclient.Authorization, path string) ([]*eosclient.FileInfo, error) { - args := []string{"oldfind", "--fileinfo", "--maxdepth", "1", path} + args := []string{"newfind", "--fileinfo", "--skip-version-dirs", "--maxdepth", "1", path} stdout, _, err := c.executeEOS(ctx, args, auth) if err != nil { return nil, errors.Wrapf(err, "eosclient: error listing fn=%s", path)