Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lints table to contain Anchor and Non-Anchor columns #90

Closed
wants to merge 2 commits into from

Conversation

S3v3ru5
Copy link
Contributor

@S3v3ru5 S3v3ru5 commented Mar 6, 2024

Updates readme to inform users which lints work on Anchor programs and which on Non Anchor programs.

Copy link
Member

@smoelius smoelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about this, TBH.

These points summarize my hesitation:

  1. Package metadata is usually consumed by tools (e.g., cargo-udeps). So this use is somewhat unconventional.
  2. Grepping the package metadata out of the Cargo.toml is kind of ugly. (On the flip side, any other approach would likely be more complicated.)
  3. Users have to manually update this data. It would be nice if Anchor/non-Anchor support could be detected automatically.

But we can let it ride and see how it goes.

@S3v3ru5
Copy link
Contributor Author

S3v3ru5 commented Mar 11, 2024

Thanks Sam. I agree with all your points. Are there other ways we can encode this information for a lint? I can try other approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants