Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve track of storage reference #82

Closed
montyly opened this issue Nov 27, 2018 · 1 comment
Closed

Improve track of storage reference #82

montyly opened this issue Nov 27, 2018 · 1 comment

Comments

@montyly
Copy link
Member

montyly commented Nov 27, 2018

In the following example, both contracts have the same outcome, but slither detects an initialized variable in Reference:

contract Reference{
    mapping (uint128 => mapping (uint256 => uint256)) map;

    function init() external{
        mapping(uint256 => uint256) tmp = map[0];
        tmp[0] = 0;
    }
}

contract Direct{
    mapping (uint128 => mapping (uint256 => uint256)) map;
    
    function init() external{
        map[0][0] = 0;
    }
}

The issue is that slither does not track the storage reference created through mapping(uint256 => uint256) tmp = map[0];, while it should.

It is close to the issue #70

@montyly
Copy link
Member Author

montyly commented Jan 9, 2019

The alias analysis is merged in master, this FP is not anymore reported

@montyly montyly closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant