Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-function-that-could-be-declared-as-external false positives #457

Closed
elenadimitrova opened this issue Apr 21, 2020 · 0 comments
Closed

Comments

@elenadimitrova
Copy link

The following informational issues have started showing up with [email protected] when running against the argent-contracts repo:

INFO:Detectors:
0: isWhitelisted(address,address) should be declared external:
	- TransferManager.isWhitelisted(address,address) (modules/TransferManager.sol#381-385)
1: isValidSignature(bytes32,bytes) should be declared external:
	- TransferManager.isValidSignature(bytes32,bytes) (modules/TransferManager.sol#415-420)
2: isLimitDisabled(address) should be declared external:
	- LimitManager.isLimitDisabled(address) (modules/common/LimitManager.sol#129-132)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#public-function-that-could-be-declared-as-external

All of the above are functions used internally in the same contract and so compilation fails if we make them external.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants