Tracking: imprecision of data dependencies on structures and arrays

[gakonst]

echo "pragma solidity ^0.5.3;

contract C {
    struct S { uint x; }

    function x() external pure returns (address) {
        S memory s;
        s.x = 1;
    }
}" > a.sol && slither a.sol

INFO:Detectors:
s in C.x() (a.sol#7) is a local variable never initialiazed
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#uninitialized-local-variables
INFO:Slither:a.sol analyzed (1 contracts with 38 detectors), 1 result(s) found

Returns that s is never initialized, when in fact we populate all of its fields in the following line
Related to #270 and #112 probably

[montyly]

Hi @gakonst,

Thank you for reporting this FP.

I think it is related to the current limitation of our IR, and the way it handles structure/mapping. It should be fixed once our IR refactoring is done (#346)

[jurajpiar]

Any advance on this?

[0xalpharush]

• [Bug-Candidate]: False positive uses timestamp for array length comparison #1436
• false positive on uninitialized local variables for fixed length arrays #884
• incorrect-equality reports false positive when comparing enums #778