Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra buggy solc versions defined #2505

Closed
joevanloon opened this issue Jul 12, 2024 · 1 comment
Closed

Extra buggy solc versions defined #2505

joevanloon opened this issue Jul 12, 2024 · 1 comment

Comments

@joevanloon
Copy link

3 solc versions are included as "buggy versions":

"0.8.23": [],
"0.8.24": [],
"0.8.25": [],

However, they have no reasoning attached because there are no lingering bugs with these versions: https://docs.soliditylang.org/en/latest/bugs.html

The "incorrect solc" detector erroneously flags these entries, because it is only checking for existence in the map:
https://github.com/crytic/slither/blob/9a5b4f5cff9db6475c5badff18f9882180d5f344/slither/detectors/attributes/incorrect_solc.py#L74C30-L74C45

These should either be removed, or the detector should filter the checked version list to just the entries that contain a non-empty list of bugs.

@0xalpharush
Copy link
Contributor

0xalpharush commented Jul 12, 2024

This was fixed here #2499. I will cut a release today

EDIT: next week ran out of time :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants