[Bug]: info from solc-version detector displays misleading message

[penandlim]

Describe the issue:

With slither 0.10.3 on a new foundry repo w/ pragma solidity 0.8.23, running slither reports below info message.

INFO:Detectors:
Version constraint 0.8.23 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
.
It is used by:
        - 0.8.23 (src/Counter.sol#2)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity

But afaik there are no known issues for solidity 0.8.23 yet.
https://solidity.readthedocs.io/en/latest/bugs.html

slither/slither/utils/buggy_versions.py

Lines 1585 to 1587 in 798c1f6

	"0.8.23": [],
	"0.8.24": [],
	"0.8.25": [],

Is this the intended info message from solc-version detector for ^0.8.23?

Code example to reproduce the issue:

// SPDX-License-Identifier: UNLICENSED
pragma solidity 0.8.23;

contract Counter {
    uint256 public number;

    function setNumber(uint256 newNumber) public {
        number = newNumber;
    }

    function increment() public {
        number++;
    }
}

Version:

0.10.3

Relevant log output:

❯ slither . 
'forge clean' running (wd: /home/me/project)
'forge config --json' running
'forge build --build-info --skip */test/** */script/** --force' running (wd: /home/me/project)
INFO:Detectors:
Version constraint 0.8.23 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
.
It is used by:
        - 0.8.23 (src/Counter.sol#2)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity
INFO:Slither:. analyzed (1 contracts with 94 detectors), 1 result(s) found

[0xalpharush]

I think this is missing a length check on bugs_by_version and should be something like if version_number in bugs_by_version and len(bugs_by_version):

slither/slither/detectors/attributes/incorrect_solc.py

Line 74 in 798c1f6

if version_number in bugs_by_version:

[MukulKolpe]

Hey @0xalpharush, can I work on this issue?

[0xalpharush]

Yes you're welcome to work on this

[halkemist]

Hi, I have the same problem on 0.8.24.