[Bug]: None when requested immediate inheritance

[Tiko7454]

Describe the issue:

When I request inheritance for contract A it gives a list consisting of B, but when I request for immediate inheritance, it gives a list with one element, which is None

Code example to reproduce the issue:

// b.sol

contract B{}

// a.sol

import {B as Base} from "b.sol";

contract A is Base {}

Version:

0.10.0

Relevant log output:

>>> slither = Slither("a.sol")
>>> A = slither.contracts[0]
>>> A.name
'A'
>>> A.inheritance
[<slither.core.declarations.contract.Contract object at 0x7f36dea24b10>]
>>> A.inheritance[0].name
'B'
>>> A.immediate_inheritance
[None]

[0xalpharush]

We probably need to resolve the alias as is done here:

slither/slither/solc_parsing/slither_compilation_unit_solc.py

Lines 437 to 440 in e3dcf1e

	if contract_name in contract_parser.underlying_contract.file_scope.renaming:
	contract_name = contract_parser.underlying_contract.file_scope.renaming[
	contract_name
	]

For base contracts, too:

slither/slither/solc_parsing/slither_compilation_unit_solc.py

Lines 456 to 464 in e3dcf1e

	# Resolve immediate base contracts
	for i in contract_parser.baseContracts:
	if i in contract_parser.remapping:
	fathers.append(
	contract_parser.underlying_contract.file_scope.get_contract_from_name(
	contract_parser.remapping[i]
	)
	# self._compilation_unit.get_contract_from_name(contract_parser.remapping[i])
	)

[Tiko7454]

I fixed the bug the way you said and opened a pr #2306

[0xalpharush]

Did it fix the issue?

[Tiko7454]

Yes