Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: there's "\n" missing from DETECTOR_INFO. #2169

Closed
partender810 opened this issue Oct 13, 2023 · 0 comments
Closed

[Bug]: there's "\n" missing from DETECTOR_INFO. #2169

partender810 opened this issue Oct 13, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@partender810
Copy link

Describe the issue:

DETECTOR_INFO contains information about the detected vulnerability, but it is difficult to read due to missing "\n" in some parts.

Code example to reproduce the issue:

Nothing was found in the outer scope

                info: DETECTOR_INFO = [
                    "Modifier ",
                    mod,
                    " does not always execute _; or revert",
                ]

this code in "slither/slither/detectors/functions/modifier.py" line 88-93.

Version:

slither WalletLibrary.sol

(https://github.com/crytic/not-so-smart-contracts/blob/master/unprotected_function/WalletLibrary_source_code/WalletLibrary.sol)

Relevant log output:

Modifier WalletLibrary.onlyowner() (WalletLibrary.sol#84-87) does not always execute _; or revertModifier WalletLibrary.onlymanyowners(bytes32) (WalletLibrary.sol#91-94) does not always execute _; or revertReference: https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-modifier

Pragma version^0.4.9 (WalletLibrary.sol#12) allows old versions
solc-0.4.22 is known to contain severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity
@partender810 partender810 added the bug-candidate Bugs reports that are not yet confirmed label Oct 13, 2023
@0xalpharush 0xalpharush added bug Something isn't working good first issue Good for newcomers and removed bug-candidate Bugs reports that are not yet confirmed labels Oct 17, 2023
@0xalpharush 0xalpharush changed the title [Bug-Candidate]: there's "\n" missing from DETECTOR_INFO. [Bug]: there's "\n" missing from DETECTOR_INFO. Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants