[False-Positive]: unimplemented-functions for mappings that contain custom types and directly implement interfaces

[PaulRBerg]

Describe the false alarm that Slither raise and how you know it's inaccurate:

Slither throws the following detector, when it shouldn't:

MyContract (...) does not implement functions:
	- MyInterface.myMapping(IERC20) (...)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#unimplemented-functions

Frequency

Very Frequently

Code example to reproduce the issue:

pragma solidity >=0.8.19;

interface IERC20 {
    function balanceOf(address) external view returns (uint256);
}

interface MyInterface {
    function myMapping(IERC20 token) external view returns (uint256 value);
}

contract MyContract is MyInterface {
    mapping(IERC20 token=> uint256 value) public override myMapping;
}

Version:

Environment:

• [email protected]
• Slither from master branch (commit 776dcab4)

Relevant log output:

No response

[0xalpharush]

I cannot reproduce this. Do you have another example?

[PaulRBerg]

It's possible that this isn't an issue with the latest version of Slither.

not able to repro now as I'm fully tied up.