Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data dependency: use fix-point on function's context #171

Closed
montyly opened this issue Feb 10, 2019 · 2 comments
Closed

Data dependency: use fix-point on function's context #171

montyly opened this issue Feb 10, 2019 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@montyly
Copy link
Member

montyly commented Feb 10, 2019

The data dependency uses a fix-point only at the contract's context, as a result, the function's context will miss some of the dependencies/taints

See: #156 (comment)

@montyly montyly added the bug Something isn't working label Feb 10, 2019
@montyly montyly added this to the 0.6.0 milestone Feb 10, 2019
@montyly montyly self-assigned this Feb 10, 2019
@montyly
Copy link
Member Author

montyly commented Feb 13, 2019

The issue is fixed in master.
We also added a new printer that should help to detect that kind of bug: data-dependency.

There is still room for improvements to the data dependency (ex: better support for self-dependency, or better support of structure and mapping), and we are going to continue to improve it's accuracy.

@cty12
Copy link

cty12 commented Feb 13, 2019

Seems to work now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants