feat: support // slither-disable-start <detectors> and // slither-disable-end <detectors>

[mds1]

Describe the desired feature

Right now you can only disable detectors for the next line, but it would very helpful to be able to disable them for larger blocks of code. A sample use case is writing solidity scripts with foundry: reentrancy is not a concern at all so I can disable reentrancy for the file, but I still want to run uninitialized variable checks to avoid passing the zero address as function inputs.

I feel like this shouldn't be too hard to implement since // slither-disable-next-line is already implemented, so if you can provide some guidance on how to add this I'm happy to take a shot to get this merged sooner 🙂

Sample usage to disable some reentrancy checks for the full file (I think this only disables one category of reentrancy checks, not sure if there's a shorthand for disabling all of them)

// slither-disable-start reentrancy-benign

pragma solidity ^0.8.16;

import "forge-std/Script.sol";
import {Counter} from "src/Counter.sol";

contract Deploy is Script {
  Counter counter;

  function run() public {
    vm.startBroadcast();
    counter = new Counter();
  }
}

[0xalpharush]

Right now, the results get filtered out here:

slither/slither/core/slither_core.py

Line 244 in 4a6ba78

if self.has_ignore_comment(r):

It currently looks at the previous line of the result:

slither/slither/core/slither_core.py

Lines 185 to 196 in 4a6ba78

	for file, lines in mapping_elements_with_lines:
	ignore_line_index = min(lines) - 1
	ignore_line_text = self.crytic_compile.get_code_from_line(file, ignore_line_index)
	if ignore_line_text:
	match = re.findall(
	r"^\s*//\s*slither-disable-next-line\s*([a-zA-Z0-9_,-]*)",
	ignore_line_text.decode("utf8"),
	)
	if match:
	ignored = match[0].split(",")
	if ignored and ("all" in ignored or any(r["check"] == c for c in ignored)):
	return True

I think it'd make sense to create and memoize a dict for each file that records what checks are disabled , and filter based off that.

if result["check"] in ignore_file_dict[file]:
  check if elems in results["elements"] overlap with range of start-end or have ignore comment on previous line 

This result is generated by each detector calling generate_result and the content depends on what was passed, e.g. a function or variable.

slither/slither/detectors/abstract_detector.py

Line 219 in a41f867

def generate_result(

related #745

Hopefully, this background info is helpful. I'm perfectly happy to answer follow-up questions if you decide to implement this.

[mds1]

Thanks! That was super helpful, just opened #1461