From 1f3285568080479548d4e2d7e3b396292159818b Mon Sep 17 00:00:00 2001
From: Simone <simone.monica@trailofbits.com>
Date: Thu, 10 Oct 2024 10:45:18 +0200
Subject: [PATCH] Add StateVariable location

---
 slither/core/variables/state_variable.py         | 14 ++++++++++++++
 slither/solc_parsing/variables/state_variable.py | 15 +++++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/slither/core/variables/state_variable.py b/slither/core/variables/state_variable.py
index f2a2d6ee3c..404cf74ba3 100644
--- a/slither/core/variables/state_variable.py
+++ b/slither/core/variables/state_variable.py
@@ -12,6 +12,7 @@ class StateVariable(ContractLevel, Variable):
     def __init__(self) -> None:
         super().__init__()
         self._node_initialization: Optional["Node"] = None
+        self._location: Optional[str] = None
 
     def is_declared_by(self, contract: "Contract") -> bool:
         """
@@ -21,6 +22,19 @@ def is_declared_by(self, contract: "Contract") -> bool:
         """
         return self.contract == contract
 
+    def set_location(self, loc: str) -> None:
+        self._location = loc
+
+    @property
+    def location(self) -> Optional[str]:
+        """
+            Variable Location
+            Can be default or transient
+        Returns:
+            (str)
+        """
+        return self._location
+
     # endregion
     ###################################################################################
     ###################################################################################
diff --git a/slither/solc_parsing/variables/state_variable.py b/slither/solc_parsing/variables/state_variable.py
index a9c0ff730b..227a84c61b 100644
--- a/slither/solc_parsing/variables/state_variable.py
+++ b/slither/solc_parsing/variables/state_variable.py
@@ -13,3 +13,18 @@ def underlying_variable(self) -> StateVariable:
         # Todo: Not sure how to overcome this with mypy
         assert isinstance(self._variable, StateVariable)
         return self._variable
+
+    def _analyze_variable_attributes(self, attributes: Dict) -> None:
+        """
+        Variable Location
+        Can be default or transient
+        """
+        if "storageLocation" in attributes:
+            self.underlying_variable.set_location(attributes["storageLocation"])
+        else:
+            # We don't have to support legacy ast
+            # as transient location was added in 0.8.28
+            # and we know it must be default
+            self.underlying_variable.set_location("default")
+
+        super()._analyze_variable_attributes(attributes)