Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax: fix incorrect handling of "%w(" #5241

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Syntax: fix incorrect handling of "%w(" #5241

merged 1 commit into from
Nov 3, 2017

Conversation

asterite
Copy link
Member

@asterite asterite commented Nov 3, 2017

Fixes #5239

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Nov 3, 2017
@asterite asterite self-assigned this Nov 3, 2017
Sija
Sija reviewed Nov 3, 2017
View reviewed changes
src/compiler/crystal/syntax/lexer.cr Outdated
@@ -2438,6 +2438,11 @@ module Crystal
next_char
end

if start == current_pos
@token.type == :EOF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be a comparison, not an assignment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed!

@RX14 RX14 added this to the Next milestone Nov 3, 2017
@RX14 RX14 merged commit 94480d9 into crystal-lang:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@RX14 RX14 RX14 approved these changes

Assignees

@asterite asterite

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@asterite @Sija @RX14