Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incorrect parsing of large handshake messages #74

Open
franziskuskiefer opened this issue Nov 22, 2023 · 1 comment
Open

[Bug] Incorrect parsing of large handshake messages #74

franziskuskiefer opened this issue Nov 22, 2023 · 1 comment
Assignees
@karthikbhargavan
Labels
bug Something isn't working

Comments

@franziskuskiefer
Copy link
Member

Parsing of large handshake messages is broken. The check for b.len() - 3 < l in check_lbytes3 fails.

To reproduce

BORINGSSL_ROOT=/path/to/boringssl ./bogo_shim/run.sh -test LargeMessage -include-disabled

See also #30
@franziskuskiefer franziskuskiefer added the bug Something isn't working label Nov 22, 2023
@karthikbhargavan
Copy link
Collaborator

I will debug this next week, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikbhargavan karthikbhargavan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franziskuskiefer @karthikbhargavan