Error when mounting with LinuxGioMounter: Message is already in session queue

[overheadhunter]

LinuxGioMounter fails to mount in some cases:

java.io.IOException: Command failed with exit code 2. Expected 0.
	at [email protected]/org.cryptomator.frontend.webdav.mount.ProcessUtil.assertExitValue(ProcessUtil.java:25)
	at [email protected]/org.cryptomator.frontend.webdav.mount.LinuxGioMounter$MountBuilderImpl.mount(LinuxGioMounter.java:97)
	... 13 more
Caused by: java.io.IOException: Stderr output: gio: dav://localhost:42427/lsLoxEBKL0GZ: Message is already in session queue
	at [email protected]/org.cryptomator.frontend.webdav.mount.ProcessUtil.assertExitValue(ProcessUtil.java:23)

@infeo found this possibly related upstream bug in gvfs: https://gitlab.gnome.org/GNOME/gvfs/-/issues/630. Looks like a trailing slash in the URL may make the difference. However I am not sure, this really changed:

With webdav-nio-adapter version 1.2.8 (Cryptomator 1.6.17) this was the implementation:

webdav-nio-adapter/src/main/java/org/cryptomator/frontend/webdav/mount/LinuxGioMounter.java

Lines 41 to 42 in b69f45d

	URI schemeCorrectedUri = new URI(mountParams.getOrDefault(MountParam.PREFERRED_GVFS_SCHEME, DEFAULT_GIO_SCHEME), uri.getSchemeSpecificPart(), null);
	ProcessBuilder mountCmd = new ProcessBuilder("sh", "-c", "gio mount \"" + schemeCorrectedUri.toASCIIString() + "\"");

With webdav-nio-adapter version 2.0.0 (Cryptomator 1.7.0) it doesn't look any different:

webdav-nio-adapter/src/main/java/org/cryptomator/frontend/webdav/mount/LinuxGioMounter.java

Lines 91 to 94 in 6feec9f

	URI schemeCorrectedUri = new URI(WEBDAV_URI_SCHEME, uri.getSchemeSpecificPart(), null);
	// mount:
	ProcessBuilder mountCmd = new ProcessBuilder("sh", "-c", "gio mount \"" + schemeCorrectedUri.toASCIIString() + "\"");

[overheadhunter]

In 1.2.8, we constructed the URI with an injected @ContextPath String contextPath, from which we explicitly removed the trailing slash:

webdav-nio-adapter/src/main/java/org/cryptomator/frontend/webdav/servlet/WebDavServletModule.java

Lines 42 to 46 in 8e5b1df

	public WebDavServletModule(Path rootPath, String contextPath) {
	String trimmedCtxPath = CharMatcher.is('/').trimTrailingFrom(contextPath);
	this.rootPath = rootPath;
	this.contextPath = trimmedCtxPath.startsWith("/") ? trimmedCtxPath : "/" + trimmedCtxPath;
	}

In 2.0.0 there is no Dagger any longer. But the normalizedContextPath() that we pass to the servlet is still not having any trailing slash:

webdav-nio-adapter/src/main/java/org/cryptomator/frontend/webdav/mount/AbstractMountBuilder.java

Lines 58 to 64 in 6feec9f

	private String normalizedContextPath() {
	return "/" + PATH_SEP_PATTERN.splitAsStream(getContextPath()).filter(Predicate.not(String::isBlank)).map(this::normalizedContextPathSegment).collect(Collectors.joining("/"));
	}
	private String normalizedContextPathSegment(String segment) {
	return RESERVED_CHARS.matcher(segment).replaceAll("_");
	}