Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: gosec fails to upload analysis results #863

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Sep 23, 2022

Solution: updated the gh action permissions

@tomtau tomtau requested a review from a team as a code owner September 23, 2022 01:47
@devashishdxt
Copy link
Collaborator

Is there a way to exclude third_party git submodules from this analysis?

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #863 (2ff7a7e) into master (3e3d7ee) will decrease coverage by 2.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   16.93%   14.28%   -2.66%     
==========================================
  Files         118      117       -1     
  Lines       14333    14116     -217     
==========================================
- Hits         2428     2016     -412     
- Misses      11413    11631     +218     
+ Partials      492      469      -23     
Flag Coverage Δ
integration_tests 14.28% <ø> (ø)
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/icaauth/types/types.go 0.00% <0.00%> (-100.00%) ⬇️
x/nft-transfer/types/packet.go 0.00% <0.00%> (-100.00%) ⬇️
x/nft-transfer/types/msgs.go 0.00% <0.00%> (-72.73%) ⬇️
x/nft/keeper/owners.go 17.02% <0.00%> (-68.09%) ⬇️
x/nft-transfer/types/genesis.go 0.00% <0.00%> (-66.67%) ⬇️
x/nft/types/msgs.go 14.15% <0.00%> (-50.01%) ⬇️
x/nft/keeper/collection.go 23.18% <0.00%> (-49.28%) ⬇️
x/nft-transfer/types/trace.go 0.00% <0.00%> (-47.62%) ⬇️
x/nft/client/cli/query.go 27.71% <0.00%> (-39.14%) ⬇️
x/nft/keeper/grpc_query.go 5.88% <0.00%> (-37.82%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tomtau
Copy link
Contributor Author

tomtau commented Sep 23, 2022

Is there a way to exclude third_party git submodules from this analysis?

maybe if it doesn't checkout the submodules?

Solution: updated the gh action permissions
@tomtau
Copy link
Contributor Author

tomtau commented Sep 23, 2022

@devashishdxt I removed the submodule checkout, so they may be empty in that workflow, we'll see if it works

@tomtau tomtau merged commit d1d04ef into crypto-org-chain:master Sep 23, 2022
devashishdxt pushed a commit to devashishdxt/chain-main that referenced this pull request Sep 23, 2022
tomtau added a commit that referenced this pull request Sep 23, 2022
Solution: updated the gh action permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants