Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ibc-go is not upgraded to v4.0.0-rc2 #826

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

devashishdxt
Copy link
Collaborator

Solution: Upgraded ibc-go to v4.0.0-rc2 and changed wasmd to different patched version.

Solution: Upgraded ibc-go to v4.0.0-rc2 and changed wasmd to different patched version
@devashishdxt devashishdxt requested a review from a team as a code owner August 2, 2022 05:44
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #826 (6ba6ca6) into master (25969bc) will increase coverage by 2.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   18.29%   20.77%   +2.48%     
==========================================
  Files          98       98              
  Lines       10761    10944     +183     
==========================================
+ Hits         1969     2274     +305     
+ Misses       8341     8181     -160     
- Partials      451      489      +38     
Flag Coverage Δ
integration_tests 18.29% <ø> (ø)
unit_tests 7.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 34.84% <0.00%> (-35.53%) ⬇️
app/state.go 0.00% <0.00%> (ø)
x/icaauth/types/params.pb.go 0.00% <0.00%> (ø)
x/nft/keeper/querier.go 9.09% <0.00%> (+0.64%) ⬆️
x/nft/keeper/invariants.go 3.63% <0.00%> (+3.63%) ⬆️
config/config.go 75.00% <0.00%> (+8.33%) ⬆️
x/icaauth/types/message_submit_tx.go 10.25% <0.00%> (+10.25%) ⬆️
x/nft/types/validation.go 52.94% <0.00%> (+14.47%) ⬆️
x/nft/keeper/keeper.go 83.33% <0.00%> (+21.21%) ⬆️
x/icaauth/types/message_register_account.go 25.00% <0.00%> (+25.00%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need a help to push the patched branch on github.com/crypto-org-chain/wasmd ?

@devashishdxt
Copy link
Collaborator Author

do you need a help to push the patched branch on github.com/crypto-org-chain/wasmd ?

I don't have write permissions on our fork. Can you push this branch to our fork? https://github.com/devashishdxt/wasmd/tree/ibc-4.0.0

go.mod Outdated Show resolved Hide resolved
@tomtau
Copy link
Contributor

tomtau commented Aug 2, 2022

@tomtau tomtau merged commit 680cc1c into crypto-org-chain:master Aug 2, 2022
devashishdxt added a commit to devashishdxt/chain-main that referenced this pull request Aug 11, 2022
Solution: Upgraded ibc-go to v4.0.0-rc2 and changed wasmd to different patched version
tomtau pushed a commit that referenced this pull request Aug 11, 2022
Solution: Upgraded ibc-go to v4.0.0-rc2 and changed wasmd to different patched version
@devashishdxt devashishdxt deleted the ibc-4.0.0 branch October 21, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants