-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: missing support for CMake (fix #265) #461
Conversation
Solution: - Add cmake support - Move the libraries and bindings to sdk
I am still working on cmake in windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should that helper.py be removed if this is now done via cmake?
It is difficult at this moment, helper.py carries some string replacement works... |
This PR adds basic cmake support, considering that the users already downloaded or built the bindings and binaries, and would like to integrate cmake into their projects. Created a follow up issue here to replace helper.py: #462 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a cmake expert, so not sure if this follows all the modern idioms: https://gist.github.com/mbinna/c61dbb39bca0e4fb7d1f73b0d66a4fd1 https://cliutils.gitlab.io/modern-cmake/ but I guess it could be potentially improved in follow up PRs
Cool references, I will check and improve in another PR, for example for #462 issue. |
Solution:
make
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
cargo build
)cargo test
)cargo fmt -- --check --color=auto
)cargo clippy
)cargo audit
)Thank you for your code, it's appreciated! :)