Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Missing integration test support for demo of play-cpp-sdk (fix #431) #432

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

damoncro
Copy link
Collaborator

@damoncro damoncro commented Jun 9, 2022

Close:

Solution:

  • Split main.cc into chainmain.cc/chainmain.h
  • Split cronos.cc into cronos.cc/cronos.h
  • Test demo program from play-cpp-sdk (using relative path) if exists

Close:
- #431

Solution:
- Split main.cc into chainmain.cc/chainmain.h
- Split cronos.cc into cronos.cc/cronos.h
- Test demo program from play-cpp-sdk (using relative path) if exists
@damoncro damoncro requested review from tomtau and leejw51crypto June 9, 2022 04:40
@damoncro
Copy link
Collaborator Author

damoncro commented Jun 9, 2022

The purpose is sharing the integration test env and example source files to play-cpp-sdk demo.

See the implementation in this PR:
cronos-labs/play-cpp-sdk#84

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe with cmake, these tests can be rewritten to use https://github.com/google/googletest ?

@damoncro
Copy link
Collaborator Author

damoncro commented Jun 9, 2022

@tomtau Ok, let's explore gtest in #265

@tomtau tomtau merged commit 7b79b75 into main Jun 9, 2022
@tomtau tomtau deleted the feat/integration_test_for_play_cpp_sdk branch June 9, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants