Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Flexible k8s smoketest #74

Closed
tthvo opened this issue Sep 19, 2023 · 5 comments
Closed

[Task] Flexible k8s smoketest #74

tthvo opened this issue Sep 19, 2023 · 5 comments
Assignees
Labels
chore Refactor, rename, cleanup, etc.

Comments

@tthvo
Copy link
Member

tthvo commented Sep 19, 2023

Right now, looks like k8s yaml(s) are hard-coded with default namespace.

https://github.com/cryostatio/cryostat3/blob/32b4f83d85de3f3dbe132a33e1f69f405b05460d/smoketest/k8s/cryostat-service.yaml#L16

We should remove this field so that the deployment namespace can be take from the kube client (i.e. oc or kubectl).

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Sep 19, 2023
@tthvo tthvo moved this to Todo in 3.0.0 release Sep 19, 2023
@andrewazores
Copy link
Member

https://github.com/cryostatio/cryostat3/blob/32b4f83d85de3f3dbe132a33e1f69f405b05460d/smoketest/k8s/smoketest.sh#L28

Maybe there is some kompose flag for this, or else there can be an additional generation step to patch the yamls in this way.

@tthvo tthvo self-assigned this Sep 20, 2023
@tthvo tthvo moved this to Todo in 3.0.0 release Sep 20, 2023
@tthvo
Copy link
Member Author

tthvo commented Sep 25, 2023

@andrewazores Would it be suitable to use Makefile in this project? Just thought it might be cleaner to put subcommand as make targets.

@andrewazores
Copy link
Member

Sure, we could do that, though if we're going to replace the smoketest.sh script I would rather spend a bit of time exploring alternatives rather than just defaulting to Makefile. For example, Taskfile.

@tthvo
Copy link
Member Author

tthvo commented Sep 26, 2023

Oh wow! That tool looks pretty neat! I will have a look into it!

@tthvo
Copy link
Member Author

tthvo commented Nov 2, 2023

I guess now that kompose does not add namespace: default to generated k8s yamls. This can be closed?

@github-project-automation github-project-automation bot moved this from Todo to Done in 3.0.0 release Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants