Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Remove PATCH recordingOptions endpoints for setting defaults? #184

Closed
andrewazores opened this issue Nov 22, 2023 · 0 comments · Fixed by #341
Closed

[Question] Remove PATCH recordingOptions endpoints for setting defaults? #184

andrewazores opened this issue Nov 22, 2023 · 0 comments · Fixed by #341
Assignees
Labels
question Further information is requested

Comments

@andrewazores
Copy link
Member

Current Behavior

The endpoint PATCH /api/v1/targets/:connectUrl/recordingOptions is an oddball and doesn't make much sense in the API, and hasn't since at least Cryostat 2.0. Perhaps it should simply be removed, or else it should be patched up to make sense and apply its settings only to the selected target. If that route is chosen, should those settings be persisted or simply held in server memory for the lifecycle of the server?

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

@andrewazores andrewazores added the question Further information is requested label Nov 22, 2023
@andrewazores andrewazores self-assigned this Nov 22, 2023
@andrewazores andrewazores moved this to Stretch Goals in 3.0.0 release Feb 20, 2024
@andrewazores andrewazores moved this from Stretch Goals to In Progress in 3.0.0 release Mar 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 3.0.0 release Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant