Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] cryostat-web should commit and push changes to src/main/webui #125

Closed
Tracked by #122
andrewazores opened this issue Oct 25, 2023 · 2 comments · Fixed by cryostatio/cryostat-web#1158 or #156
Closed
Tracked by #122
Labels

Comments

@andrewazores
Copy link
Member

andrewazores commented Oct 25, 2023

There is CI integration in the cryostat-web repo that causes a bot account to push any merges into that repo's main branch into the web-client submodule of cryostat 2.x. We should have the same integration here (except into the equivalent src/main/webui submodule path) so that the web UI for this project is also kept up-to-date with the latest development on the -web client repo.

@aali309
Copy link
Contributor

aali309 commented Nov 7, 2023

There is CI integration in the cryostat-web repo that causes a bot account to push any merges into that repo's main branch into the web-client submodule of cryostat 2.x. We should have the same integration here (except into the equivalent src/main/webui submodule path) so that the web UI for this project is also kept up-to-date with the latest development on the -web client repo.

we just need to update this?
https://github.com/cryostatio/cryostat-web/tree/52a0ef0840f1eaa2064247df32bc87d4f0e231a8/.github/workflows

@andrewazores
Copy link
Member Author

I think this: https://github.com/cryostatio/cryostat-web/blob/main/.github/workflows/submodule.yaml

For now while we're transitioning from Cryostat 2.x to this Cryostat3 repo, I guess that -web workflow should be updated to update the submodules on both 2.x and 3. In the future we would drop 2.x so it only updates this 3 repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
2 participants