Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Remove gson in favour of jackson #101

Closed
andrewazores opened this issue Oct 13, 2023 · 3 comments · Fixed by #188
Closed

[Task] Remove gson in favour of jackson #101

andrewazores opened this issue Oct 13, 2023 · 3 comments · Fixed by #188
Assignees
Labels
chore Refactor, rename, cleanup, etc.

Comments

@andrewazores
Copy link
Member

andrewazores commented Oct 13, 2023

Some code carried forward from the old repository included gson as a dependency. Elsewhere we also have a dependency on Jackson via Quarkus, and more recently via projectnessie CEL as well. Gson should be dropped and all usages converted to use Jackson instead.

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Oct 13, 2023
@andrewazores
Copy link
Member Author

andrewazores commented Oct 25, 2023

Upon review, Gson only actually gets pulled in for one usage in an integration test util in JvmIdWebRequest, which currently is only called from the disabled custom targets integration test. Should be very easy to replace but will be difficult to validate that the replacement is functioning correctly without a working test case.

The pom.xml already scopes the dependency for test only so this would not affect actual container distributions.

@andrewazores andrewazores moved this to Todo in 3.0.0 release Oct 25, 2023
@lkonno
Copy link
Contributor

lkonno commented Oct 25, 2023

@andrewazores The JvmIdWebRequest uses the graphql to query the jvmId of the targetId, so it seems that it will depend on the graphql endpoint implementation to re-enable this test.

@andrewazores
Copy link
Member Author

Thanks for checking on that @lkonno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants