[Bug] Raw HTTP error response displayed when uploading actions fail

[andrewazores]

Current Behavior

When ex. uploading a JMX SSL cert, if the upload fails for any reason, the notification popup displayed shows the raw HTTP response JSON payload.

Expected Behavior

The error message should be nicely formatted, and more concise/informative.

Steps To Reproduce

1. run smoketest.sh
2. go to Security view
3. try to upload an SSL cert more than once, ex. https://github.com/andrewazores/vertx-fib-demo/blob/master/src/main/extras/app/resources/vertx-fib-demo.cer
4. go to Automated Rules
5. create a rule
6. download the rule
7. delete the rule
8. try to upload the same rule twice

Environment

No response

Anything else?

[andrewazores]

Upload requests go through here:

cryostat-web/src/app/Shared/Services/Api.service.tsx

Line 1408 in bdcdfb5

private sendLegacyRequest(

Error handling happens here:

cryostat-web/src/app/Shared/Services/Api.service.tsx

Line 1504 in bdcdfb5

this.notifications.danger(`Request failed (${error.xmlHttpResponse.status} ${error.message})`, detail);

Since this is not a WebSocket notification like most other graphical notifications that appear, we would need callers to pass in more details for notifications like the title that should appear on the notification. We could try to parse the detail body as JSON and use the detail.data.reason as the message to display, and if that fails simply show detail directly.