-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(scorecard): retry on cryostat update conflict #774
Conversation
d567ae5
to
d29db67
Compare
/build_test |
|
/build_test |
|
The test failure seems to be the same as #774 (comment). Maybe rebase lost the changes? |
06f6260
to
2f7b5e6
Compare
/build_test |
|
/build_test |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @mwangggg! Just needs a rebase with make scorecard-build MANIFEST_PUSH=false bundle
.
4330933
to
2ee1241
Compare
2ee1241
to
bf29937
Compare
/build_test |
|
@Mergifyio backport cryostat3 |
✅ Backports have been created
|
* retry on cryostat update conflict * review * review (cherry picked from commit d7b0379) # Conflicts: # bundle/manifests/cryostat-operator.clusterserviceversion.yaml # bundle/tests/scorecard/config.yaml # config/scorecard/patches/custom.config.yaml # internal/test/scorecard/common_utils.go # internal/test/scorecard/tests.go
) * test(scorecard): retry on cryostat update conflict (#774) * retry on cryostat update conflict * review * review (cherry picked from commit d7b0379) # Conflicts: # bundle/manifests/cryostat-operator.clusterserviceversion.yaml # bundle/tests/scorecard/config.yaml # config/scorecard/patches/custom.config.yaml # internal/test/scorecard/common_utils.go # internal/test/scorecard/tests.go * Fix conflicts --------- Co-authored-by: Ming Yu Wang <[email protected]> Co-authored-by: Elliott Baron <[email protected]>
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #757