Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(scorecard): multi-namespace scorecard test for 3.0 #773

Merged
merged 2 commits into from
Apr 5, 2024
Merged

test(scorecard): multi-namespace scorecard test for 3.0 #773

merged 2 commits into from
Apr 5, 2024

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Mar 20, 2024 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #539

  • adds multi-namespace scorecard test for Cryostat 3.0
  • amends all the scorecard tests to use operatorv1beta2 resources instead of operatorv1beta1
  • removes mention of clustercryostats in bundle & config files

@mergify mergify bot added the safe-to-test label Mar 20, 2024
@mwangggg mwangggg added the test label Mar 21, 2024
@mwangggg mwangggg force-pushed the 539-multi-namespace-scorecard branch 2 times, most recently from fbe9ce1 to 794a0b6 Compare March 27, 2024 19:53
@mwangggg
Copy link
Member Author

mwangggg commented Apr 3, 2024

/build_test

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

/build_test : At least one test failed ❌.
View Actions Run.

@mwangggg mwangggg force-pushed the 539-multi-namespace-scorecard branch from 30e2623 to 2797265 Compare April 4, 2024 17:11
@mwangggg mwangggg force-pushed the 539-multi-namespace-scorecard branch from a715525 to 0043aef Compare April 4, 2024 17:22
@ebaron
Copy link
Member

ebaron commented Apr 5, 2024

/build_test

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

/build_test completed successfully ✅.
View Actions Run.

ebaron
ebaron approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mwangggg!

@ebaron ebaron merged commit 461096c into cryostatio:cryostat3 Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@ebaron ebaron ebaron approved these changes

@andrewazores andrewazores Awaiting requested review from andrewazores

Assignees
No one assigned
Labels
safe-to-test test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwangggg @ebaron @tthvo