Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(scorecard): multi-namespace scorecard test #763

Merged
merged 4 commits into from
Apr 5, 2024
Merged

test(scorecard): multi-namespace scorecard test #763

merged 4 commits into from
Apr 5, 2024

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Mar 14, 2024 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #539

Multi-namespace scorecard test for 2.x operator

@mwangggg mwangggg requested review from ebaron and tthvo March 14, 2024 16:06
@mwangggg mwangggg marked this pull request as draft March 14, 2024 19:46
@mwangggg mwangggg force-pushed the 539-cluster-scorecard branch 3 times, most recently from a50b1d9 to fe914bc Compare March 19, 2024 15:21
@mwangggg mwangggg marked this pull request as ready for review March 19, 2024 15:43
@mwangggg
Copy link
Member Author

/build_test

@mwangggg
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

/build_test completed successfully ✅.
View Actions Run.

@mwangggg mwangggg force-pushed the 539-cluster-scorecard branch 4 times, most recently from 079396d to 08bc8dc Compare March 20, 2024 15:04
tthvo
tthvo reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

--------------------------------------------------------------------------------
Image:      quay.io/thvo/cryostat-operator-scorecard:2.5.0-20240320145712
Entrypoint: [cryostat-scorecard-tests cryostat-multi-namespace]
Labels:
    "suite":"cryostat"
    "test":"cryostat-multi-namespace"
Results:
    Name: cryostat-multi-namespace
    State: pass

    Log:
        created namespace: other-scorecard-namespace
        deployment cryostat-multi-namespace is not yet found
        deployment cryostat-multi-namespace is not yet found
        deployment cryostat-multi-namespace is not yet found
        deployment cryostat-multi-namespace is not yet found
        deployment cryostat-multi-namespace is not yet found
        deployment cryostat-multi-namespace is not yet found
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is not yet available
        deployment cryostat-multi-namespace is available
        application has access to the following namespaces: [other-scorecard-namespace]
        application is available at https://testing.cryostat

@mwangggg
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

/build_test completed successfully ✅.
View Actions Run.

@mwangggg mwangggg force-pushed the 539-cluster-scorecard branch from 08bc8dc to 08b9f07 Compare March 27, 2024 18:01
@mwangggg mwangggg force-pushed the 539-cluster-scorecard branch from 08b9f07 to 754691a Compare March 27, 2024 19:14
ebaron
ebaron reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ming, looks good! Just one small suggestion about the namespace name.

internal/test/scorecard/tests.go Outdated Show resolved Hide resolved
@mwangggg mwangggg force-pushed the 539-cluster-scorecard branch from c9e31d8 to d621f7a Compare April 4, 2024 17:18
@ebaron
Copy link
Member

ebaron commented Apr 5, 2024

/build_test

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit 6b63e3f into cryostatio:main Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@andrewazores andrewazores andrewazores left review comments

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
safe-to-test test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom scorecard test for multi-namespace Cryostat CR
4 participants
@mwangggg @ebaron @andrewazores @tthvo