Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Breaking CRD changes for 3.0 #731

Closed
4 tasks done
ebaron opened this issue Feb 13, 2024 · 7 comments
Closed
4 tasks done

[Epic] Breaking CRD changes for 3.0 #731

ebaron opened this issue Feb 13, 2024 · 7 comments
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request

Comments

@ebaron
Copy link
Member

ebaron commented Feb 13, 2024

Some CRD options no longer make sense for Cryostat 3.0. These include:

@ebaron ebaron added feat New feature or request breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere labels Feb 13, 2024
@tthvo
Copy link
Member

tthvo commented Mar 27, 2024

Hey @ebaron, is there any planned for 3.0 tasks that I can help you here?

@ebaron
Copy link
Member Author

ebaron commented Apr 3, 2024

Hey @ebaron, is there any planned for 3.0 tasks that I can help you here?

Hey @tthvo, I think there may be some additional breaking changes that will follow #710. Some things we discussed were removing parts or all of the Authorization Properties as this is no longer used in 3.0. The Cluster Role could still make sense for the OpenShift oauth-proxy, but the mapping file won't be used. The credentials database password might need to be moved/renamed.

@tthvo
Copy link
Member

tthvo commented Apr 4, 2024

Thanks Elliott! I would love to help out with those changes anytime once #710 is completed :D

@ebaron
Copy link
Member Author

ebaron commented Apr 5, 2024

Thanks @tthvo! I will keep this epic open and add any such changes to it.

@tthvo
Copy link
Member

tthvo commented May 13, 2024

Hey @ebaron I think its pretty much done in #808?

@andrewazores
Copy link
Member

Can this be closed now?

@andrewazores andrewazores moved this to In Progress in 3.0.0 release Jun 7, 2024
@ebaron
Copy link
Member Author

ebaron commented Jun 7, 2024

Yeah I think we're done with API changes for 3.0 at this point

@ebaron ebaron closed this as completed Jun 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 3.0.0 release Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants