Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update github actions to node 16 #639

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Sep 29, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #638

Description of the change:

This change updates GitHub actions node version from 12 that is deprecated to v16

Motivation for the change:

Running workflows produces warning of the deprecated node 12 version

How to manually test:

  1. Insert steps here...
  2. ...

@mwangggg
Copy link
Member

mwangggg commented Sep 29, 2023

actions/github-script@v4 still uses node12 so we want to update it to v6 as it uses node16, just with the replacement for github.reactions.createForIssueComment and github.pulls.get

@mwangggg mwangggg self-requested a review October 3, 2023 17:53
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@ebaron ebaron force-pushed the replaceDeprecatednode12 branch from d8f4a1e to 5a1ae37 Compare October 3, 2023 20:17
@ebaron
Copy link
Member

ebaron commented Oct 3, 2023

Hey @aali309, would you be able to rebase? I tried GitHub's automated rebase, but it seems to have made the commits unverified.

@andrewazores
Copy link
Member

Hey @aali309, would you be able to rebase? I tried GitHub's automated rebase, but it seems to have made the commits unverified.

https://github.com/orgs/community/discussions/11639

@aali309 aali309 force-pushed the replaceDeprecatednode12 branch from 5a1ae37 to f0321b8 Compare October 3, 2023 21:11
@aali309
Copy link
Contributor Author

aali309 commented Oct 3, 2023

Hey @aali309, would you be able to rebase? I tried GitHub's automated rebase, but it seems to have made the commits unverified.

done

@ebaron ebaron merged commit b896e4d into cryostatio:main Oct 3, 2023
5 checks passed
@aali309 aali309 deleted the replaceDeprecatednode12 branch October 4, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Upgrade PR actions to versions that use node16 <title>
5 participants