-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Port Rules engine from Nashorn to GraalVM JS #990
Comments
Here is an interesting alternative: https://github.com/google/cel-spec From the outset, using a parser-restricted JavaScript subset for the The Common Expression Language meets these goals by having a very similar and familiar syntax, having a small and non-Turing-complete language, and having a Java implementation that we can mostly plug-and-play on the Cryostat server. This is unlikely to be 100% syntax compatible with existing JavaScript-based matchExpressions, so changing the implementation in this way should be held for a major version. |
Closing. 3.0 now uses Project Nessie cel-java, not a JavaScript engine. |
Related to #274 - when ported to Quarkus, Nashorn should definitely be dropped in favour of Graal/Mandrel's implementation. Can the downstream product depend on the GraalVM impl below?
Nashorn was already deprecated in JDK11 and has been fully removed from the main JDK in more recent releases. There is still a separate upstream https://github.com/openjdk/nashorn project that we can pull in as a replacement dependency, but it would probably be even better to switch to GraalVM's JS implementation.
https://www.graalvm.org/22.1/reference-manual/js/NashornMigrationGuide/
https://www.graalvm.org/22.1/reference-manual/js/RunOnJDK/
The text was updated successfully, but these errors were encountered: