Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Localize and refactor Automated Analysis Rules throughout codebase #1464

Open
2 of 4 tasks
maxcao13 opened this issue Apr 20, 2023 · 0 comments
Open
2 of 4 tasks
Labels
chore Refactor, rename, cleanup, etc. feat New feature or request

Comments

@maxcao13
Copy link
Member

maxcao13 commented Apr 20, 2023

Describe the feature

From some discussion about re-formatting front-end rendering of Automated Analysis results because of the recent cryostat-core bump which updated JMC to version 8, there are mutliple sections of the entire codebase that need to be fixed up to better handle cryostat's Automated Analysis Reports.

cryostat-core:

  • RuleFilterParser:
    Currently, outside of directly querying the -reports api, the filter is not being used at all and cryostat requests the entire analysis, without filtering, which is okay. This may need testing, I'm not fully sure whether the report generation still supports the predicate filtering feature with the new updates.

cryostat-reports:

  • -reports will need to be updated if it's possible to pass a locale in a request to -core reportGenerator for localized/translated reports. Otherwise from what I can tell, the reports sidecar does not need to be updated since it uses the -core classes other than a pom.xml bump.

cryostat:

  • server side will also need to pass in a locale if applicable, same as -reports

cryostat-web

@maxcao13 maxcao13 added feat New feature or request chore Refactor, rename, cleanup, etc. needs-triage Needs thorough attention from code reviewers labels Apr 20, 2023
@maxcao13 maxcao13 moved this to Todo in 2.4.0 release Apr 20, 2023
@maxcao13 maxcao13 changed the title [Epic] Localize and refactor Automated Analysis Rules throughout codebase [Story] Localize and refactor Automated Analysis Rules throughout codebase Apr 20, 2023
@andrewazores andrewazores moved this from Todo to Backlog in 2.4.0 release May 23, 2023
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. feat New feature or request
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

2 participants