Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] JFR operations require MissionControlMXBean #447

Open
andrewazores opened this issue Aug 22, 2024 · 1 comment
Open

[Bug] JFR operations require MissionControlMXBean #447

andrewazores opened this issue Aug 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@andrewazores
Copy link
Member

I think that probably explains the difference in behaviour for different operations, though. The Dashboard MBean Metrics views are powered by opening a JMX connection and directly invoking remote calls on various M(X)Beans, like the OperatingSystemMXBean or MemoryMXBean. JFR operations like starting a recording or listing .jfc event templates open a JMX connection and then go through a JMC library call stack, which I'm sure hits that HotspotManagementToolkit and therefore requires the MissionControl MXBean.

Originally posted by @andrewazores in cryostatio/cryostat#595 (reply in thread)

@andrewazores andrewazores added bug Something isn't working question Further information is requested labels Aug 22, 2024
@andrewazores
Copy link
Member Author

TODO: investigate feasibility of removing the linked toolkit class from the call path. It doesn't seem like we really need the MissionControlMXBean for Cryostat's purposes.

Removing the JMC dependencies from the JFR management operation call paths would also do the job, but would be a very large refactoring job related to #223, #173.

Either directly reimplementing the operations, or using a simpler library like https://github.com/microsoft/jfr-streaming , could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants