Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-refresh feature doesn't work with Nucleus template. #251

Open
jumarko opened this issue Feb 9, 2022 · 1 comment
Open

Auto-refresh feature doesn't work with Nucleus template. #251

jumarko opened this issue Feb 9, 2022 · 1 comment

Comments

@jumarko
Copy link
Contributor

jumarko commented Feb 9, 2022

As discussed on Slack (https://clojurians.slack.com/archives/C0M8UK760/p1644436501870119?thread_ts=1644318541.889299&cid=C0M8UK760)
the ring's auto-refresh functionality doesn't work because nucleaus uses custom window.onload function.

I fixed this in my clone by commenting out this portion of the Nucleus template: curiousprogrammer-net/curiousprogrammer.blog@fe12141
However, I'm not sure what's the proper way to do this generically so I've just created this issue without submitting a PR.

@holyjak
Copy link
Contributor

holyjak commented Mar 4, 2022

IMO the correct fix would be to call also the previous onload:

const oldOnload = window.onload;
window.onload = () => { if (oldOnload) oldOnload(); externalLinks(); }

would you care to send a Pr with that? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants