Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mongodb error handling #94

Open
aero31aero opened this issue Jul 19, 2017 · 2 comments
Open

Fix mongodb error handling #94

aero31aero opened this issue Jul 19, 2017 · 2 comments
Labels
bug priority

Comments

@aero31aero
Copy link
Member

Handle cases of no data found elegantly. Example: App would crash on trying to fetch incorrect events.

Fix: Use if (err || !data) type constructs. Do a pass through the whole codebase for similar errors.
@aero31aero aero31aero added this to the Landing milestone Jul 19, 2017
@rogeredthat
Copy link
Member

Update: Partial migration has been done. Also, we need to migrate to promises instead. See sample commit here: 95b3d95

@rogeredthat rogeredthat removed this from the Landing milestone Sep 26, 2017
@aero31aero
Copy link
Member Author

@sohailrajdev97 if possible do a sweep of the project code file by file and fix such bugs after Atmos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aero31aero @rogeredthat