Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability improvements to conversion webhooks #369

Open
mbbush opened this issue Mar 9, 2024 · 0 comments
Open

Stability improvements to conversion webhooks #369

mbbush opened this issue Mar 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mbbush
Copy link
Contributor

mbbush commented Mar 9, 2024

What problem are you facing?

When I installed provider-aws-kafka v1.0.0 (which contained a v1beta2 resource) into a cluster running crossplane 1.12, a TLS certificate error caused the provider to crash loop, which rendered all the resources it managed basically unusable. The TLS issue was fixed in crossplane-contrib/provider-upjet-aws#1157, and while I have not yet found any other issues that could cause the conversion webhooks to crash, I am concerned that their failure had such a large blast radius.

How could Upjet help solve your problem?

Could we run the conversion webhooks in such a way that if they panic, they don't take down the entire provider with them? Perhaps in a sidecar container?

@mbbush mbbush added the enhancement New feature or request label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant